Fix references links #33759
Fix references links #33759
Conversation
There are Duplicate link references in the article and the format is incorrect.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -171,12 +171,10 @@ and a length. | |||
| ## Slicing syntax | |||
|
|
|||
| You can use a combo of `&` and `[]` to create a slice from various things. The | |||
| `&` indicates that slices are similar to [references], which we will cover in | |||
| `&` indicates that slices are similar to [references][references], which we will cover in | |||
There was a problem hiding this comment.
This should actually be identical in Markdown, and I prefer this style. Can you revert these two changes, and just leave the deletion on 178? Thanks!
There was a problem hiding this comment.
But the [references] style cannot be convert to PDF/LaTex correctly with Pandoc. And the converted result is still [references] in the LaTex source instead of references with a link reference.
If it's [references][references] or references][] as defined in the Markdown Syntax, the Pandoc tools can convert it to LaTex or PDF correctly.
There was a problem hiding this comment.
I found that it was the trpl-ebook that could not tell the [references] style. If I use Pandoc to convert the articles to PDF or Tex format directly, it will get the right result regardless of [references], [references][] or [references][references].
There was a problem hiding this comment.
CommonMark, which pandoc is supposed to implement explicitly allows this.
There was a problem hiding this comment.
@steveklabnik I have reverted these two changes. Thanks so much!
|
@bors: r+ rollup |
|
📌 Commit 4c7b963 has been approved by |
Fix references links There are duplicate link references in the article and just remove one of them.
There are duplicate link references in the article and just remove one of them.