Cleanup macro expansion and improve diagnostics #33766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jseyfried
force-pushed
the
cleanup_expansion
branch
from
eef1114 to
392a785
Compare
…he post-expansion visitor
jseyfried
force-pushed
the
cleanup_expansion
branch
from
bea2846 to
3c421ac
Compare
|
Damn, @jseyfied, you've been busy :-) |
| &fld.cx.parse_sess.codemap(), | ||
| &fld.cx.ecfg.features.unwrap()); | ||
| } | ||
| trait MacroGenerable: Sized { |
There was a problem hiding this comment.
Could you comment on what this trait is for, what should implement it, etc.
|
r+ with the extra comment |
|
@nrc I added some comments. |
jseyfried
force-pushed
the
cleanup_expansion
branch
from
a19c884 to
e9c0283
Compare
|
@bors: r+ |
|
📌 Commit e9c0283 has been approved by |
This was referenced May 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup macro expansion and improve diagnostics. Fixes #33709.
r? @nrc