Factor TokenTrees into their own file in preparation for TokenStreams. #34044
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Travis build failure seems unrelated to code; failed on an |
|
@cgswords: Don't worry, travis is broken for the moment. |
| use print::pprust; | ||
| use ptr::P; | ||
| use tokenstream::{TokenTree}; |
There was a problem hiding this comment.
Would a pub use here avoid the breakage?
|
r=me with the formatting nit addressed and the tests fixed. |
|
Formatting and tests are fixed. |
|
☔ The latest upstream changes (presumably #34272) made this pull request unmergeable. Please resolve the merge conflicts. |
syntax-[breaking-change] cc #31645
(Only breaking because
ast::TokenTreeis nowtokenstream::TokenTree.)This pull request refactors TokenTrees into their own file as
src/libsyntax/tokenstream.rs, moving them out ofsrc/libsyntax/ast.rs, in order to prepare for an accompanying TokenStream implementation (per RFC 1566).r? @nrc