Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an abs_path member to FileMap, use it when writing debug info. #34187

Merged
merged 1 commit into from
Jun 16, 2016
Merged

Add an abs_path member to FileMap, use it when writing debug info. #34187

merged 1 commit into from
Jun 16, 2016

Commits on Jun 16, 2016

  1. Add an abs_path member to FileMap, use it when writing debug info. 

    When items are inlined from extern crates, the filename in the debug info
is taken from the FileMap that's serialized in the rlib metadata.
Currently this is just FileMap.name, which is whatever path is passed to rustc.
Since libcore and libstd are built by invoking rustc with relative paths,
they wind up with relative paths in the rlib, and when linked into a binary
the debug info uses relative paths for the names, but since the compilation
directory for the final binary, tools trying to read source filenames
will wind up with bad paths. We noticed this in Firefox with source
filenames from libcore/libstd having bad paths.

This change stores an absolute path in FileMap.abs_path, and uses that
if available for writing debug info. This is not going to magically make
debuggers able to find the source, but it will at least provide sensible
paths.
    @luser
    luser committed Jun 16, 2016
    Configuration menu
    Copy the full SHA
    24e7491 View commit details
    Browse the repository at this point in the history