rustdoc: Fix redirect pages for renamed reexports #34245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
👍 |
| if let ItemType::Module = ty { | ||
| write!(url, "{}/index.html", target_name).unwrap(); | ||
| } else { | ||
| write!(url, "{}.{}.html", ty.to_static_str(), target_name).unwrap(); |
There was a problem hiding this comment.
This seems duplicated with item_path, perhaps the two could be refactored to share code?
We need to use the name of the target not the name of the current item when creating the link.
ollie27
force-pushed
the
rustdoc_redirect_rename
branch
from
43eaa4a
to
0c742d2
Compare
|
⌛ Testing commit 0c742d2 with merge f46ed6f... |
|
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
|
@bors: retry
On Tue, Jun 14, 2016 at 8:58 PM, bors notifications@github.com wrote:
|
bors
added a commit
that referenced
this pull request
Jun 15, 2016
rustdoc: Fix redirect pages for renamed reexports We need to use the name of the target not the name of the current item when creating the link. An example in `std` is [`std::sys::ext`](https://doc.rust-lang.org/nightly/std/sys/ext/index.html).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to use the name of the target not the name of the current item
when creating the link.
An example in
stdisstd::sys::ext.