Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow MultiItemModifiers to expand into zero or many items #34253

Merged
merged 4 commits into from
Jun 23, 2016
Merged

Allow MultiItemModifiers to expand into zero or many items #34253

merged 4 commits into from
Jun 23, 2016

Conversation

jseyfried
Copy link
Contributor

@jseyfried jseyfried commented Jun 13, 2016 •
edited
Loading

Fixes #34223.
r? @nrc

@jseyfried
Copy link
Contributor Author

jseyfried commented Jun 13, 2016 •
edited
Loading

While this is a syntax-[breaking-change] in theory, it is highly unlikely to cause breakage in practice. In particular, it will not break any crates on github.

After this PR, MultiItemModifiers will be at least as powerful as MultiItemDecorators, except that MultiItemDecorators have access to expanded AST (c.f. #34010). If we revert #34010 and instead fix #32950 some other way (c.f. this comment), MultiItemModifiers will be at least as powerful as MultiItemDecorators without exception.

@jseyfried jseyfried mentioned this pull request Jun 13, 2016
Closed
@jseyfried jseyfried force-pushed the improve_multi_modifiers branch 7 times, most recently from 0978ba2 to 8cb439d Compare June 15, 2016 09:12
@jseyfried jseyfried force-pushed the improve_multi_modifiers branch from 5af255a to 58372af Compare June 16, 2016 05:46
@nrc
Copy link
Member

nrc commented Jun 23, 2016

@bors: r+

@bors
Copy link
Contributor

bors commented Jun 23, 2016

📌 Commit 58372af has been approved by nrc

@nrc nrc mentioned this pull request Jun 23, 2016
Closed
@bors
Copy link
Contributor

bors commented Jun 23, 2016

⌛ Testing commit 58372af with merge 3908913...

bors added a commit that referenced this pull request Jun 23, 2016
@bors
Auto merge of #34253 - jseyfried:improve_multi_modifiers, r=nrc
3908913 
Allow `MultiItemModifier`s to expand into zero or many items

Fixes #34223.
r? @nrc
@bors
Copy link
Contributor

bors commented Jun 23, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

@bors bors merged commit 58372af into rust-lang:master Jun 23, 2016
This was referenced Jun 23, 2016
Merged
Closed
@jseyfried jseyfried mentioned this pull request Jul 5, 2016
Merged
@jseyfried jseyfried mentioned this pull request Jul 21, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nrc nrc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jseyfried @nrc @bors