Perform cfg attribute processing on decorator-generated items
#34295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -787,8 +787,6 @@ fn decorate(a: Annotatable, fld: &mut MacroExpander) -> SmallVector<Annotatable> | |||
| let mut decorator_items = SmallVector::zero(); | |||
| let mut new_attrs = Vec::new(); | |||
| expand_decorators(a.clone(), fld, &mut decorator_items, &mut new_attrs); | |||
| let decorator_items = | |||
| decorator_items.into_iter().flat_map(|a| expand_annotatable(a, fld)).collect(); | |||
There was a problem hiding this comment.
decorator_items are already expanded in expand_decorators().
I mistakenly added this in #34010. Since expansion is idempotent, it didn't cause bugs, just regressed expansion performance.
jseyfried
force-pushed
the
cfg_decoration
branch
from
294a4ad to
c41cf30
Compare
|
@bors r+ |
|
📌 Commit c41cf30 has been approved by |
|
@eddyb Thanks! |
bors
added a commit
that referenced
this pull request
Jun 19, 2016
Perform `cfg` attribute processing on decorator-generated items Fixes https://users.rust-lang.org/t/unused-attribute-warning-for-custom-derive-attribute/6180. r? @nrc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://users.rust-lang.org/t/unused-attribute-warning-for-custom-derive-attribute/6180.
r? @nrc