Remove redundant CompileController entry points
#34480
Conversation
|
I could reintroduce the However, I'm not sure if having an entry point here would be useful enough to justify the added complexity -- @nrc what do you think? |
|
I think it would be nice to have an entry point after expansion and before HIR lowering. I can imagine tools which want to operate on the expanded AST, but don't need the HIR or complete name resolution. |
|
@nrc Ok, I'll add |
jseyfried
force-pushed
the
remove_entry_points
branch
from
471f36c
to
a1d03f6
Compare
|
@nrc I rebased and added a commit that reintroduces |
jseyfried
force-pushed
the
remove_entry_points
branch
3 times, most recently
from
7d86328
to
6c1b582
Compare
|
@bors: r+ |
|
📌 Commit 6c1b582 has been approved by |
…rest of name resolution
jseyfried
force-pushed
the
remove_entry_points
branch
from
6c1b582
to
d1e3d62
Compare
|
@bors r=nrc (fixed the commit message) |
|
📌 Commit d1e3d62 has been approved by |
|
⌛ Testing commit d1e3d62 with merge f29f8c2... |
|
💔 Test failed - auto-win-msvc-64-opt-rustbuild |
|
@bors: retry On Fri, Jul 1, 2016 at 5:34 AM, bors notifications@github.com wrote:
|
|
⌛ Testing commit d1e3d62 with merge 2ce10f5... |
|
💔 Test failed - auto-win-msvc-64-opt-rustbuild |
|
@bors retry |
Remove redundant `CompileController` entry points Remove the `after_expand` and `after_write_deps` `CompileController` entry points. The only things that separate these entry points from `after_hir_lowering` are dep-info generation and HIR map construction, neither of which is computationally intensive or has the potential to error. r? @nrc
Remove the
after_expandandafter_write_depsCompileControllerentry points.The only things that separate these entry points from
after_hir_loweringare dep-info generation and HIR map construction, neither of which is computationally intensive or has the potential to error.r? @nrc