Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cfg_attr on path attributes #34546

Merged
merged 2 commits into from
Jul 6, 2016
Merged

Conversation

jseyfried
Copy link
Contributor

@jseyfried jseyfried commented Jun 29, 2016

Fixes #25544.
This is technically a [breaking-change]. For example, the following would break:

#[cfg_attr(all(), path = "nonsense.rs")]
mod foo; // Suppose `foo.rs` existed in the appropriate location

@nagisa
Copy link
Member

nagisa commented Jun 29, 2016

cc @rust-lang/lang

@eddyb
Copy link
Member

eddyb commented Jun 29, 2016

Crater report shows only 2 false positives, no relevant regressions.

@jseyfried
Copy link
Contributor Author

@eddyb Excellent!

@jseyfried
Copy link
Contributor Author

r? @nrc

@rust-highfive rust-highfive assigned nrc and unassigned eddyb Jul 5, 2016
@nrc
Copy link
Member

nrc commented Jul 5, 2016

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 5, 2016

📌 Commit 2ef02e1 has been approved by nrc

@bors
Copy link
Contributor

bors commented Jul 6, 2016

⌛ Testing commit 2ef02e1 with merge 11bca98...

@bors
Copy link
Contributor

bors commented Jul 6, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@jseyfried
Copy link
Contributor Author

@bors r=nrc

@bors
Copy link
Contributor

bors commented Jul 6, 2016

📌 Commit ba59d42 has been approved by nrc

@bors
Copy link
Contributor

bors commented Jul 6, 2016

⌛ Testing commit ba59d42 with merge 4738076...

bors added a commit that referenced this pull request Jul 6, 2016
Support `cfg_attr` on `path` attributes

Fixes #25544.
This is technically a [breaking-change]. For example, the following would break:
```rust
mod foo; // Suppose `foo.rs` existed in the appropriate location
```
@bors bors merged commit ba59d42 into rust-lang:master Jul 6, 2016
@jseyfried jseyfried deleted the cfg_attr_path branch September 14, 2016 21:20
Centril added a commit to Centril/rust that referenced this pull request Mar 22, 2020
Remove another wrong entry from RELEASES.md

The entry is under 1.11.0, but the feature is only available since 1.12.0 (for which an identical entry exists).

![Screenshot_2020-03-22 Support `cfg_attr` on `path` attributes by jseyfried · Pull Request rust-lang#34546 · rust-lang rust](https://user-images.githubusercontent.com/951129/77238862-85c8f580-6bd4-11ea-8d31-77e2994a4b5a.png)
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 22, 2020
Remove another wrong entry from RELEASES.md

The entry is under 1.11.0, but the feature is only available since 1.12.0 (for which an identical entry exists).

![Screenshot_2020-03-22 Support `cfg_attr` on `path` attributes by jseyfried · Pull Request rust-lang#34546 · rust-lang rust](https://user-images.githubusercontent.com/951129/77238862-85c8f580-6bd4-11ea-8d31-77e2994a4b5a.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants