Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variant Size Differences: Erase regions before computing type layout #34846

Merged
merged 1 commit into from
Jul 17, 2016
Merged

Variant Size Differences: Erase regions before computing type layout #34846

merged 1 commit into from
Jul 17, 2016

Conversation

jonas-schievink
Copy link
Contributor

Fixes #34839

@rust-highfive
Copy link
Collaborator

r? @Aatch

(rust_highfive has picked a reviewer for you, use r? to override)

@jonas-schievink
Copy link
Contributor Author

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned Aatch Jul 16, 2016
@eddyb
Copy link
Member

eddyb commented Jul 16, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Jul 16, 2016

📌 Commit d148610 has been approved by eddyb

@eddyb
Copy link
Member

eddyb commented Jul 16, 2016

cc @brson This should fix the recent regressions you've found.

@sfackler
Copy link
Member

@bors p=1

@bors
Copy link
Contributor

bors commented Jul 16, 2016

⌛ Testing commit d148610 with merge bb8f413...

@alexcrichton
Copy link
Member

@bors: retry force clean

  • I accidentally hit the merge button

@bors
Copy link
Contributor

bors commented Jul 16, 2016

⌛ Testing commit d148610 with merge 9d35d68...

bors added a commit that referenced this pull request Jul 16, 2016
@bors
Auto merge of #34846 - jonas-schievink:issue34839, r=eddyb
9d35d68 
Variant Size Differences: Erase regions before computing type layout

Fixes #34839
@bors
Copy link
Contributor

bors commented Jul 16, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@arielb1
Copy link
Contributor

arielb1 commented Jul 16, 2016

@bors retry

@eddyb
Copy link
Member

eddyb commented Jul 16, 2016

@arielb1 That failure is likely @alexcrichton's accidental manual merge of #34836.

@bors
Copy link
Contributor

bors commented Jul 16, 2016

⚡ Previous build results for auto-win-msvc-64-cargotest are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild...

eddyb added a commit to eddyb/rust that referenced this pull request Jul 16, 2016
@eddyb
Rollup merge of rust-lang#34846 - jonas-schievink:issue34839, r=eddyb
f3bee35 
Variant Size Differences: Erase regions before computing type layout

Fixes rust-lang#34839
@eddyb eddyb mentioned this pull request Jul 16, 2016
Closed
@bors
Copy link
Contributor

bors commented Jul 16, 2016

⛄ The build was interrupted to prioritize another pull request.

@eddyb eddyb mentioned this pull request Jul 16, 2016
Merged
@bors
Copy link
Contributor

bors commented Jul 16, 2016

⌛ Testing commit d148610 with merge b5ad277...

bors added a commit that referenced this pull request Jul 16, 2016
@bors
Auto merge of #34846 - jonas-schievink:issue34839, r=eddyb
b5ad277 
Variant Size Differences: Erase regions before computing type layout

Fixes #34839
@bors
Copy link
Contributor

bors commented Jul 17, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild
Approved by: eddyb
Pushing b5ad277 to master...

@bors bors merged commit d148610 into rust-lang:master Jul 17, 2016
@TimNN TimNN mentioned this pull request Jul 17, 2016
Closed
@jonas-schievink jonas-schievink deleted the issue34839 branch July 17, 2016 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jonas-schievink @rust-highfive @eddyb @bors @sfackler @alexcrichton @arielb1 @Aatch