Clean up and encapsulate syntax::ext::mtwt, rename mtwt to hygiene
#34860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jseyfried
force-pushed
the
encapsulate_hygiene
branch
from
17871ee to
804486b
Compare
|
|
||
| // create a fresh mark. | ||
| pub fn fresh_mark() -> ast::Mrk { | ||
| gensym("mark").0 |
There was a problem hiding this comment.
🎉 (this might be the only remaining "legitimate" use of gensym)
and that would be painful to rewrite.
jseyfried
force-pushed
the
encapsulate_hygiene
branch
from
804486b to
275d321
Compare
|
@bors: r+ |
|
📌 Commit 275d321 has been approved by |
|
⌛ Testing commit 275d321 with merge 165c5f7... |
|
💔 Test failed - auto-win-gnu-32-opt |
|
@bors: retry On Sun, Jul 17, 2016 at 7:10 PM, bors notifications@github.com wrote:
|
bors
added a commit
that referenced
this pull request
Jul 18, 2016
Clean up and encapsulate `syntax::ext::mtwt`, rename `mtwt` to `hygiene` r? @nrc
This was referenced Jul 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nrc