Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: Remove soft-float from MIPS targets #34910

Merged
merged 1 commit into from
Jul 21, 2016

Commits on Jul 19, 2016

  1. rustc: Remove soft-float from MIPS targets

    Right now two MIPS targets in the compiler, `mips-unknown-linux-{gnu,musl}` both
    generate object files using the soft-float ABI through LLVM by default. This is
    also expressed as the `-C soft-float` codegen option and otherwise isn't used
    for any other target in the compiler. This option was added quite some time ago
    (back in rust-lang#9617), and nowadays it's more appropriate to be done through a codegen
    option.
    
    This is motivated by rust-lang#34743 which necessitated an upgrade in the CMake
    installation on our bots which necessitated an upgrade in the Ubuntu version
    which invalidated the MIPS compilers we were using. The new MIPS compilers
    (coming from Debian I believe) all have hard float enabled by default and soft
    float support not built in. This meant that we couldn't upgrade the bots
    until rust-lang#34841 landed because otherwise we would fail to compile C code as the
    `-msoft-float` option wouldn't work.
    
    Unfortunately, though, this means that once we upgrade the bots the C code we're
    compiling will be compiled for hard float and the Rust code will be compiled
    for soft float, a bad mismatch! This PR remedies the situation such that Rust
    will compile with hard float as well.
    
    If this lands it will likely produce broken nightlies for a day or two while we
    get around to upgrading the bots because the current C toolchain only produces
    soft-float binaries, and now rust will be hard-float. Hopefully, though, the
    upgrade can go smoothly!
    alexcrichton committed Jul 19, 2016
    Configuration menu
    Copy the full SHA
    f77bcc8 View commit details
    Browse the repository at this point in the history