Fix wrong condition in base::internalize_symbols(). #34917
Conversation
|
r? @Aatch (rust_highfive has picked a reviewer for you, use r? to override) |
|
Would be nice if you could add a test, but otherwise r=me. |
|
This fixes #34891 for me. |
|
@TimNN Excellent |
|
@bors r+ |
|
📌 Commit f782088 has been approved by |
|
The travis failure looks legit to me. Edit: Making |
|
@bors r- 'till that's fixed. |
|
Yes, the error looks legit. The internalizer does not take the |
|
Alright, that seems to have worked. @eddyb, care to review that last commit too? |
|
|
||
| // Collect all external declarations in all compilation units. | ||
| for ccx in cx.iter() { | ||
| // Collect all symbols that need stay externally visible because they |
There was a problem hiding this comment.
whoops, typo: "need to stay"
|
r=me with the typo fixed. |
michaelwoerister
force-pushed
the
fix-internalize-symbols
branch
from
e5c4b16 to
ecc1295
Compare
|
@bors r=eddyb |
|
📌 Commit ecc1295 has been approved by |
|
⌛ Testing commit ecc1295 with merge a7af87c... |
|
💔 Test failed - auto-linux-64-cargotest |
|
@bors: retry On Wed, Jul 20, 2016 at 5:51 PM, bors notifications@github.com wrote:
|
|
⌛ Testing commit ecc1295 with merge 1caeab7... |
|
💔 Test failed - auto-win-gnu-32-opt |
|
@bors: retry sorry for the number of retries... On Thu, Jul 21, 2016 at 12:30 PM, bors notifications@github.com wrote:
|
|
@bors p=1 this may fix a huge regr in compiler perf |
Fix wrong condition in base::internalize_symbols(). Fix a typo that snuck into #34899 (and completely broke `internalize_symbols()`).
Fix a typo that snuck into #34899 (and completely broke
internalize_symbols()).