Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CSS] Fix unwanted top margin for toggle wrapper #34921

Merged
merged 1 commit into from
Jul 21, 2016
Merged

[CSS] Fix unwanted top margin for toggle wrapper #34921

merged 1 commit into from
Jul 21, 2016

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jul 19, 2016 •
edited
Loading

Fixes top margin.

Before:

before

After (check "A view into a single entry in map" toggle wrapper more precisely):

after

r? @steveklabnik

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jul 19, 2016

📌 Commit 4a2116b has been approved by steveklabnik

@bors
Copy link
Contributor

bors commented Jul 20, 2016

⌛ Testing commit 4a2116b with merge 78eea9d...

@bors
Copy link
Contributor

bors commented Jul 20, 2016

💔 Test failed - auto-win-msvc-64-cargotest

@alexcrichton
Copy link
Member

@bors: retry

On Tue, Jul 19, 2016 at 10:09 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-cargotest
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-cargotest/builds/1174

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#34921 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95PV2d-hU0TveE1Iz-FCQ54qtyLl9ks5qXa12gaJpZM4JPtLN
.

@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 20, 2016
Closed
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 20, 2016
Merged
@bors
Copy link
Contributor

bors commented Jul 21, 2016

⌛ Testing commit 4a2116b with merge 29a8ed7...

@bors
Copy link
Contributor

bors commented Jul 21, 2016

💔 Test failed - auto-linux-64-cargotest

@alexcrichton
Copy link
Member

@bors: retry

On Wed, Jul 20, 2016 at 6:33 PM, bors notifications@github.com wrote:

💔 Test failed - auto-linux-64-cargotest
https://buildbot.rust-lang.org/builders/auto-linux-64-cargotest/builds/1204

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#34921 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95EC3KBX_Pa5GoswfcEW8JIpl3Zflks5qXsxigaJpZM4JPtLN
.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 21, 2016
@GuillaumeGomez
Rollup merge of rust-lang#34921 - GuillaumeGomez:css_fix, r=steveklabnik
3f3dabb 
[CSS] Fix unwanted top margin for toggle wrapper

Fixes top margin.

Before:

![before](https://cloud.githubusercontent.com/assets/3050060/16950833/72b2b956-4dc2-11e6-9d27-24507871b5a8.png)

After (check "A view into a single entry in map" toggle wrapper more precisely):

![after](https://cloud.githubusercontent.com/assets/3050060/16950839/7835c6fc-4dc2-11e6-901a-ae8c4191baca.png)

r? @steveklabnik
bors added a commit that referenced this pull request Jul 21, 2016
@bors
Auto merge of #34939 - GuillaumeGomez:rollup, r=GuillaumeGomez
7588653 
Rollup of 7 pull requests

- Successful merges: #34854, #34855, #34880, #34895, #34911, #34921, #34930
- Failed merges: #33951, #34850
@bors bors merged commit 4a2116b into rust-lang:master Jul 21, 2016
@GuillaumeGomez GuillaumeGomez deleted the css_fix branch July 21, 2016 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumeGomez @steveklabnik @bors @alexcrichton