Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std: Fix usage of SOCK_CLOEXEC #34946

Merged
merged 1 commit into from
Jul 28, 2016
Merged

std: Fix usage of SOCK_CLOEXEC #34946

merged 1 commit into from
Jul 28, 2016

Conversation

alexcrichton
Copy link
Member

This code path was intended to only get executed on Linux, but unfortunately the
cfg! was malformed so it actually never got executed.

@alexcrichton
std: Fix usage of SOCK_CLOEXEC
15cd5a1 
This code path was intended to only get executed on Linux, but unfortunately the
`cfg!` was malformed so it actually never got executed.
@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@brson
Copy link
Contributor

brson commented Jul 21, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Jul 21, 2016

📌 Commit 15cd5a1 has been approved by brson

@brson brson added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 21, 2016
@bors
Copy link
Contributor

bors commented Jul 21, 2016

⌛ Testing commit 15cd5a1 with merge 4b0371c...

@bors
Copy link
Contributor

bors commented Jul 21, 2016

💔 Test failed - auto-linux-64-cargotest

@alexcrichton
Copy link
Member Author

@bors: retry

On Wed, Jul 20, 2016 at 6:01 PM, bors notifications@github.com wrote:

💔 Test failed - auto-linux-64-cargotest
https://buildbot.rust-lang.org/builders/auto-linux-64-cargotest/builds/1194

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95JX_cwRUN9dmuS56Vz6pHH6eD2Sdks5qXsTagaJpZM4JRVeA
.

@bors
Copy link
Contributor

bors commented Jul 21, 2016

⌛ Testing commit 15cd5a1 with merge 4b24e08...

@bors
Copy link
Contributor

bors commented Jul 21, 2016

💔 Test failed - auto-win-msvc-64-opt-mir

@alexcrichton
Copy link
Member Author

@bors: retry

On Thu, Jul 21, 2016 at 12:39 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-opt-mir
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-mir/builds/1504

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95Labf_72DTySjVrco2zfV0cAkkLyks5qX8r_gaJpZM4JRVeA
.

@bors
Copy link
Contributor

bors commented Jul 22, 2016

⌛ Testing commit 15cd5a1 with merge 1054428...

@bors
Copy link
Contributor

bors commented Jul 22, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@alexcrichton
Copy link
Member Author

@bors: retry

On Fri, Jul 22, 2016 at 4:17 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt-rustbuild/builds/1912

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95KakrrcAF6y0trCPm3znaSIZZ2nmks5qYU-BgaJpZM4JRVeA
.

@bors
Copy link
Contributor

bors commented Jul 23, 2016

⌛ Testing commit 15cd5a1 with merge 1bdc162...

bors added a commit that referenced this pull request Jul 23, 2016
@bors
Auto merge of #34946 - alexcrichton:fix-cfg, r=brson
1bdc162 
std: Fix usage of SOCK_CLOEXEC

This code path was intended to only get executed on Linux, but unfortunately the
`cfg!` was malformed so it actually never got executed.
@bors
Copy link
Contributor

bors commented Jul 23, 2016

💔 Test failed - auto-linux-64-x-android-t

@arielb1
Copy link
Contributor

arielb1 commented Jul 23, 2016

@bors retry

@alexcrichton
Copy link
Member Author

@bors: retry

@bors
Copy link
Contributor

bors commented Jul 25, 2016

⌛ Testing commit 15cd5a1 with merge d33473b...

@bors
Copy link
Contributor

bors commented Jul 25, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@alexcrichton
Copy link
Member Author

@bors: retry

On Sun, Jul 24, 2016 at 10:47 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt-rustbuild/builds/1925

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95LkDh18vC9B9hGz5fkoYmvtVqqT6ks5qZE3dgaJpZM4JRVeA
.

@alexcrichton
Copy link
Member Author

@bors: retry

@bors
Copy link
Contributor

bors commented Jul 25, 2016

⌛ Testing commit 15cd5a1 with merge 65b403a...

@bors
Copy link
Contributor

bors commented Jul 25, 2016

💔 Test failed - auto-win-gnu-32-opt

@alexcrichton
Copy link
Member Author

@bors: retry

On Mon, Jul 25, 2016 at 2:59 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt/builds/5070

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95CF2J5CF1UW_cperKIrl6WJOq7l2ks5qZTGpgaJpZM4JRVeA
.

@bors
Copy link
Contributor

bors commented Jul 26, 2016

⌛ Testing commit 15cd5a1 with merge d510024...

@bors
Copy link
Contributor

bors commented Jul 26, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@alexcrichton
Copy link
Member Author

@bors: retry

On Tue, Jul 26, 2016 at 3:20 AM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt-rustbuild/builds/1953

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95I18rfRgI-2FdCGnvjaFyhA70NGqks5qZd-GgaJpZM4JRVeA
.

@bors
Copy link
Contributor

bors commented Jul 28, 2016

⌛ Testing commit 15cd5a1 with merge f5d7952...

bors added a commit that referenced this pull request Jul 28, 2016
@bors
Auto merge of #34946 - alexcrichton:fix-cfg, r=brson
f5d7952 
std: Fix usage of SOCK_CLOEXEC

This code path was intended to only get executed on Linux, but unfortunately the
`cfg!` was malformed so it actually never got executed.
@bors
Copy link
Contributor

bors commented Jul 28, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild
Approved by: brson
Pushing f5d7952 to master...

@bors bors merged commit 15cd5a1 into rust-lang:master Jul 28, 2016
@alexcrichton alexcrichton deleted the fix-cfg branch August 26, 2016 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
relnotes Marks issues that should be documented in the release notes of the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexcrichton @rust-highfive @brson @bors @arielb1 @aturon