Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non existent field err code #34954

Conversation

GuillaumeGomez
Copy link
Member

Fixes #34914.

I'm not very proud of this way of doing it but it's the easiest solution I found.

r? @jonathandturner

@sophiajt
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jul 21, 2016

📌 Commit 7ec4615 has been approved by jonathandturner

@arielb1
Copy link
Contributor

arielb1 commented Jul 21, 2016

This should probably be based on #34907.

@bors r-

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jul 22, 2016

@arielb1: Do you have an idea when your PR will get merged? If it's in more than 4 days, I think mine can totally get merged.

@arielb1
Copy link
Contributor

arielb1 commented Jul 22, 2016

I will cherry-pick your PR.

@GuillaumeGomez
Copy link
Member Author

Ah nice, thanks!

@arielb1
Copy link
Contributor

arielb1 commented Jul 22, 2016

Done (521ada1). Closing this one.

@arielb1 arielb1 closed this Jul 22, 2016
@GuillaumeGomez GuillaumeGomez deleted the non_existent_field_err_code branch November 24, 2017 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants