Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never build gcc_personality_v0.c #35034

Closed
wants to merge 2 commits into from
Closed

Conversation

jakllsch
Copy link
Contributor

Refs #29977

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Thanks for the PR! When combined with #35032 I don't think we actually need this any more, and this also broke freebsd, so could you try out just removing this file entirely? Could you also be sure to delete its reference from the makefiles as well?

@jakllsch jakllsch changed the title Only build gcc_personality_v0.c on NetBSD if targeting ARM Never build gcc_personality_v0.c Jul 25, 2016
@bors
Copy link
Contributor

bors commented Jul 31, 2016

☔ The latest upstream changes (presumably #35004) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton
Copy link
Member

Closing due to inactivity, but feel free to resubmit with a rebase!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants