typeck: use a TypeVisitor in ctp #35143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
|
📌 Commit 0a128f3 has been approved by |
|
⌛ Testing commit 0a128f3 with merge 7333c4a... |
bors
added a commit
that referenced
this pull request
Jul 31, 2016
typeck: use a TypeVisitor in ctp Use a TypeVisitor in ctp instead of `ty::walk` This fixes a few cases where a region could be projected out of a trait while not being constrained by the type parameters, violating rust-lang/rfcs#447 and breaking soundness. As such, this is a [breaking-change]. Fixes #35139 r? @eddyb
|
Crater report shows 1 root regression: cc @rust-lang/lang |
diwic
added a commit
to diwic/dbus-rs
that referenced
this pull request
Aug 2, 2016
This is due to a soundness fix in rustc: rust-lang/rust#35143 Signed-off-by: David Henningsson <diwic@ubuntu.com>
|
Given the minimal impact, this doesn't require a warning period, but we still ought to do our best to minimize impact before landing and help users. e.g. give an explanatory note on the error indicating that there was a recent bug-fix (it'd be ok, I think, for that note to appear even if the error would have happened before), and/or submit a PR to fix the problem. Still, given that this landed, I'm not inclined to roll it back. Just saying. cc @Kimundi -- this change fixes a hole that the "owning-ref" crate was relying on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a TypeVisitor in ctp instead of
ty::walkThis fixes a few cases where a region could be projected out of a trait while not being constrained by the type parameters, violating rust-lang/rfcs#447 and breaking soundness. As such, this is a [breaking-change].
Fixes #35139
r? @eddyb