Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdb: Fix pretty-printing special-cased Rust types #35585

Merged
merged 1 commit into from
Aug 31, 2016

Conversation

Kha
Copy link
Contributor

@Kha Kha commented Aug 11, 2016

gdb trunk now reports fully qualified type names, just like lldb. Move lldb code for extracting unqualified names to shared file.

For current releases of gdb, extract_type_name should just be a no-op.

Fixes #35155

gdb trunk now reports fully qualified type names, just like lldb. Move
lldb code for extracting unqualified names to shared file.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@aturon
Copy link
Member

aturon commented Aug 27, 2016

r? @michaelwoerister

@michaelwoerister
Copy link
Member

@bors r+

Thanks for the PR, looks good to me!

@bors
Copy link
Contributor

bors commented Aug 29, 2016

📌 Commit 4714072 has been approved by michaelwoerister

@bors
Copy link
Contributor

bors commented Aug 30, 2016

⌛ Testing commit 4714072 with merge 2582133...

@bors
Copy link
Contributor

bors commented Aug 30, 2016

💔 Test failed - auto-mac-64-opt

@alexcrichton
Copy link
Member

@bors: retry

On Tue, Aug 30, 2016 at 12:20 PM, bors notifications@github.com wrote:

💔 Test failed - auto-mac-64-opt
https://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/10368


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#35585 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95DcPRJTRNfKjyF4ukXlkltLHVeojks5qlIKMgaJpZM4JhwNH
.

@bors
Copy link
Contributor

bors commented Aug 31, 2016

⌛ Testing commit 4714072 with merge 824000a...

bors added a commit that referenced this pull request Aug 31, 2016
gdb: Fix pretty-printing special-cased Rust types

gdb trunk now reports fully qualified type names, just like lldb. Move lldb code for extracting unqualified names to shared file.

For current releases of gdb, `extract_type_name` should just be a no-op.

Fixes #35155
@bors bors merged commit 4714072 into rust-lang:master Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants