Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label to E0254 #35596

Merged
merged 2 commits into from
Aug 15, 2016
Merged

Add label to E0254 #35596

merged 2 commits into from
Aug 15, 2016

Conversation

tvladyslav
Copy link
Contributor

This issue #35513 is a part of #35233.
r? @jonathandturner

This issue #35513 is a part of #35233.
r? @jonathandturner
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@tvladyslav tvladyslav mentioned this pull request Aug 11, 2016
@sophiajt
Copy link
Contributor

Great, almost there. You'll need to run this through tidy and fix the errors. After that, it looks like it's ready:

python src/bootstrap/bootstrap.py --stage 1 --step check-tidy

@sophiajt
Copy link
Contributor

Great!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 12, 2016

📌 Commit c761184 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 13, 2016
…ts, r=jonathandturner

Add label to E0254

This issue rust-lang#35513 is a part of rust-lang#35233.
r? @jonathandturner
eddyb added a commit to eddyb/rust that referenced this pull request Aug 14, 2016
…ts, r=jonathandturner

Add label to E0254

This issue rust-lang#35513 is a part of rust-lang#35233.
r? @jonathandturner
eddyb added a commit to eddyb/rust that referenced this pull request Aug 14, 2016
…ts, r=jonathandturner

Add label to E0254

This issue rust-lang#35513 is a part of rust-lang#35233.
r? @jonathandturner
bors added a commit that referenced this pull request Aug 14, 2016
@bors bors merged commit c761184 into rust-lang:master Aug 15, 2016
@tvladyslav tvladyslav deleted the E0254_style_and_tests branch August 15, 2016 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants