Refactoring ReaderUtil trait, combining it with the traitless impl on Reader #3589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Merged. |
|
Thanks! I noticed there were a few test cases I forgot to update. Did you catch these? |
|
Yep! |
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2021
Catch panics from the parser while rewriting macro calls
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
May 11, 2024
io::Error handling: keep around the full io::Error for longer so we can give better errors This should help with the error message in rust-lang/miri#3587.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.