Fix documentation in cell mod #35895
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -121,22 +121,26 @@ | |||
| //! ``` | |||
| //! use std::cell::Cell; | |||
| //! | |||
| //! struct Rc<T> { | |||
| //! ptr: *mut RcBox<T> | |||
| //! pub struct Rc<T: ?Sized> { | |||
There was a problem hiding this comment.
Agree. The pub keyword is removed.
|
Seems like the build failure is spurious. I share @GuillaumeGomez 's question about |
|
Travis failed. Run: make tidyto see what's wrong. |
|
Hm, still a strange failure. Let's see how it does on real CI, thanks! @bors: r+ rollup |
|
📌 Commit 424698b has been approved by |
| //! | ||
| //! trait RcBoxPtr<T: ?Sized> { | ||
| //! fn inc_strong(&self) { | ||
| //! self.inner().strong.set(self.strong().checked_add(1).unwrap_or_else(|| unsafe { abort() })); |
There was a problem hiding this comment.
This is still over 100 columns wide, please split into multiple lines.
|
@bors r- |
|
And run |
|
And please squash your commits. |
|
@steveklabnik Just Ping. Could you please help to merge this PR? |
|
@bors r=steveklabnik |
|
📌 Commit f4c55dd has been approved by |
|
⌛ Testing commit f4c55dd with merge 404d580... |
|
💔 Test failed - auto-mac-64-opt-rustbuild |
|
@bors retry |
Fix documentation in cell mod The implementation of Rc type in this doc is outdated.
Fix documentation in cell mod The implementation of Rc type in this doc is outdated.
Fix documentation in cell mod The implementation of Rc type in this doc is outdated.
The implementation of Rc type in this doc is outdated.