Do not report cast errors if an error had been previously detected #35899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `InferCtxt` is tainted by errors, the result of `CastCheck::do_check` may fail even though the cast is valid. We don't want any wrong error messages in those cases so checking `is_tainted_by_errors()` before reporting cast errors. Fixes rust-lang#35772
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
Relevant failures start here in the Travis log. Looks like quite a few of the tests actually included this error and now need to be updated. |
|
I somehow manage to miss these failed tests when running |
|
Okay, it looks like my solution to the problem was a bit too simple and actually broke a bunch of relevant error messages. I'll try to think a different approach instead and reopen this PR then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
InferCtxtis tainted by errors, the result ofCastCheck::do_checkmay fail even though the cast is valid. We don't want any wrong error messages in those cases so checkingis_tainted_by_errors()before reporting cast errors.Fixes #35772.