Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update E0445 and E0454 to new error format #35961

Merged
merged 1 commit into from
Aug 25, 2016
Merged

Update E0445 and E0454 to new error format #35961

merged 1 commit into from
Aug 25, 2016

Conversation

0xmohit
Copy link
Contributor

@0xmohit 0xmohit commented Aug 24, 2016

Fixes #35922.
Fixes #35930.
Part of #35233.

r? @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Aug 24, 2016

📌 Commit b5d9237 has been approved by GuillaumeGomez

@0xmohit 0xmohit force-pushed the pr/error-codes-E0445-E0454 branch 3 times, most recently from b6f98c6 to 11e9b8d Compare August 24, 2016 12:57
@sophiajt
Copy link
Contributor

Weird, bors didn't pick this one up. Trying again.

@bors r=GuillaumeGomez

@bors
Copy link
Contributor

bors commented Aug 24, 2016

📌 Commit 11e9b8d has been approved by GuillaumeGomez

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 24, 2016
Rollup merge of rust-lang#35961 - 0xmohit:pr/error-codes-E0445-E0454,…
2932db1 
… r=GuillaumeGomez

Update E0445 and E0454 to new error format

Fixes rust-lang#35922.
Fixes rust-lang#35930.
Part of rust-lang#35233.

r? @GuillaumeGomez
@sophiajt sophiajt mentioned this pull request Aug 24, 2016
Merged
bors added a commit that referenced this pull request Aug 25, 2016
@bors
Auto merge of #35971 - jonathandturner:rollup, r=jonathandturner
0ccd5c8 
Rollup of 4 pull requests

- Successful merges: #35876, #35920, #35948, #35961
- Failed merges: #35395
@bors bors merged commit 11e9b8d into rust-lang:master Aug 25, 2016
@0xmohit 0xmohit deleted the pr/error-codes-E0445-E0454 branch August 25, 2016 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0xmohit @rust-highfive @GuillaumeGomez @bors @sophiajt