Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Fix associated consts in search results #36078

Merged
merged 1 commit into from
Sep 6, 2016

Conversation

ollie27
Copy link
Member

@ollie27 ollie27 commented Aug 28, 2016

Associated consts can appear in none trait impls so need to be treated
like methods when generating the search index.

Fixes #36031

@rust-highfive
Copy link
Collaborator

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

@bors
Copy link
Contributor

bors commented Aug 28, 2016

☔ The latest upstream changes (presumably #35984) made this pull request unmergeable. Please resolve the merge conflicts.

Associated consts can appear in none trait impls so need to be treated
like methods when generating the search index.
@ollie27 ollie27 force-pushed the rustdoc_search_assocconst branch from c09fbf3 to b56d61c Compare August 29, 2016 17:47
@Manishearth
Copy link
Member

Manishearth commented Sep 3, 2016

r? @alexcrichton

This breaks the doc build, could this be reviewed?

(PR lgtm but I am not as familiar with the rustdoc internals)

Testing locally for the full doc build now.

@alexcrichton
Copy link
Member

@bors: r+ b56d61c

@bors
Copy link
Contributor

bors commented Sep 6, 2016

⌛ Testing commit b56d61c with merge 1d04201...

bors added a commit that referenced this pull request Sep 6, 2016
rustdoc: Fix associated consts in search results

Associated consts can appear in none trait impls so need to be treated
like methods when generating the search index.

Fixes #36031
@bors bors merged commit b56d61c into rust-lang:master Sep 6, 2016
@ollie27 ollie27 deleted the rustdoc_search_assocconst branch September 8, 2016 20:59
nikomatsakis added a commit to nikomatsakis/rust that referenced this pull request Nov 21, 2016
Setup two tasks, one of which only processes the signatures, in order to
isolate the typeck entries for signatures from those for bodies.

Fixes rust-lang#36078
Fixes rust-lang#37720
flodiebold pushed a commit to flodiebold/rust that referenced this pull request Nov 29, 2016
Setup two tasks, one of which only processes the signatures, in order to
isolate the typeck entries for signatures from those for bodies.

Fixes rust-lang#36078
Fixes rust-lang#37720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants