-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: Fix associated consts in search results #36078
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(rust_highfive has picked a reviewer for you, use r? to override) |
☔ The latest upstream changes (presumably #35984) made this pull request unmergeable. Please resolve the merge conflicts. |
Associated consts can appear in none trait impls so need to be treated like methods when generating the search index.
ollie27
force-pushed
the
rustdoc_search_assocconst
branch
from
August 29, 2016 17:47
c09fbf3
to
b56d61c
Compare
This breaks the doc build, could this be reviewed? (PR lgtm but I am not as familiar with the rustdoc internals) Testing locally for the full doc build now. |
bors
added a commit
that referenced
this pull request
Sep 6, 2016
rustdoc: Fix associated consts in search results Associated consts can appear in none trait impls so need to be treated like methods when generating the search index. Fixes #36031
nikomatsakis
added a commit
to nikomatsakis/rust
that referenced
this pull request
Nov 21, 2016
Setup two tasks, one of which only processes the signatures, in order to isolate the typeck entries for signatures from those for bodies. Fixes rust-lang#36078 Fixes rust-lang#37720
flodiebold
pushed a commit
to flodiebold/rust
that referenced
this pull request
Nov 29, 2016
Setup two tasks, one of which only processes the signatures, in order to isolate the typeck entries for signatures from those for bodies. Fixes rust-lang#36078 Fixes rust-lang#37720
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated consts can appear in none trait impls so need to be treated
like methods when generating the search index.
Fixes #36031