Issue deprecation warnings for safe accesses to extern statics #36173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -207,6 +207,10 @@ pub fn register_builtins(store: &mut lint::LintStore, sess: Option<&Session>) { | |||
| id: LintId::of(LIFETIME_UNDERSCORE), | |||
| reference: "RFC 1177 <https://github.com/rust-lang/rfcs/pull/1177>", | |||
| }, | |||
| FutureIncompatibleInfo { | |||
| id: LintId::of(SAFE_EXTERN_STATICS), | |||
| reference: "issue 35112 <https://github.com/rust-lang/rust/issues/35112>", | |||
There was a problem hiding this comment.
the new policy is to make a separate tracking issue, following roughly this template; if you could update with an issue like that, it'd be great.
3 tasks
|
@nikomatsakis |
|
Looks great. =) |
|
@bors r+ |
|
📌 Commit ef489fc has been approved by |
|
⌛ Testing commit ef489fc with merge 4391d8e... |
|
💔 Test failed - auto-win-msvc-64-opt-rustbuild |
|
@bors r=nikomatsakis |
|
📌 Commit aadbcff has been approved by |
bluss
added
the
relnotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35112
cc #36247