Updated e0493 to new format (+ bonus). #36212
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
|
||
| const F : Foo = Foo { a : 0 }; | ||
| //~^ ERROR constants are not allowed to have destructors [E0493] | ||
| //~| NOTE constants cannot have destructors |
There was a problem hiding this comment.
Because we're updating the span, can you move this test over to somewhere in the src/test/ui directory so that we can test the output?
UI tests are pretty straightforward. The compiler runs them then compares the output with the corresponding .stderr file. If they match, it passes. You can look at the other .stderr files to see how it's done.
There was a problem hiding this comment.
Interesting, I didn't know about this. :) Done!
|
Cool :) @bors r+ |
|
📌 Commit 059094f has been approved by |
…t, r=jonathandturner Updated e0493 to new format (+ bonus). Part of rust-lang#35233. Fixes rust-lang#35999. r? @jonathandturner I'm not satisfied with the bonus part, there has to be an easier way to reach into the `Drop`'s span implementation. I'm all ears. :)
…t, r=jonathandturner Updated e0493 to new format (+ bonus). Part of rust-lang#35233. Fixes rust-lang#35999. r? @jonathandturner I'm not satisfied with the bonus part, there has to be an easier way to reach into the `Drop`'s span implementation. I'm all ears. :)
Part of #35233.
Fixes #35999.
r? @jonathandturner
I'm not satisfied with the bonus part, there has to be an easier way to reach into the
Drop's span implementation. I'm all ears. :)