Avoid instaiblity errors in code generated by syntax_ext::deriving::call_intrinsic()
#36316
Conversation
| callee: codemap::NameAndSpan { | ||
| format: codemap::MacroAttribute(intern(&format!("derive({})", tname))), | ||
| span: Some(titem.span), | ||
| allow_internal_unstable: true, |
There was a problem hiding this comment.
What about adding this block of code to call_intrinsic instead? It's about the same amount of work and wouldn't hide unstable feature usage like the previous implementation did.
jseyfried
force-pushed
the
custom_derive_internal_unstable
branch
from
173b47d to
8eeb57c
Compare
jseyfried
changed the title
syntax_ext::deriving::call_intrinsic()
|
You could probably now replace |
jseyfried
force-pushed
the
custom_derive_internal_unstable
branch
3 times, most recently
from
ad75287 to
f5f11b3
Compare
jseyfried
force-pushed
the
custom_derive_internal_unstable
branch
from
f5f11b3 to
d6ea10e
Compare
|
@bors r=eddyb |
|
📌 Commit d6ea10e has been approved by |
…ddyb Avoid instaiblity errors in code generated by `syntax_ext::deriving::call_intrinsic()` r? @eddyb
|
cc @alexcrichton. |
|
Gah, sorry about the regression! It's not clear to me here what actually regressed, but the solution looks fine. |
|
@alexcrichton no worries. |
|
Ah I see, that'd explain the lack of regressions in the main repo! |
#35957 made old-style attribute syntax extensions no longer allow internal instability.
r? @eddyb