add static_in_const feature gate #36332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also updates tests and deletes the spurious .bk files I inadvertently added last time.
| self.tcx | ||
| .sess | ||
| .struct_span_warn(span, | ||
| "This needs a `'static` lifetime or the \ |
There was a problem hiding this comment.
Nit: it should be this not This, and this should be an error :)
|
@chriskrycho I even added a sentence about the feature gate to the reference. |
|
@llogiq awesome. I'll see if I can add the docs for the feature itself over the weekend! |
|
📌 Commit 76a2f9f has been approved by |
|
Thank you @nikomatsakis for the awesome mentoring. |
bors
added a commit
that referenced
this pull request
Sep 10, 2016
add static_in_const feature gate also updates tests and deletes the spurious .bk files I inadvertently added last time. r? @nikomatsakis
This was referenced Sep 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also updates tests and deletes the spurious .bk files I inadvertently added last time.
r? @nikomatsakis