Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example in AsMut trait documentation #36519

Merged
merged 1 commit into from
Sep 16, 2016

Conversation

Mark-Simulacrum
Copy link
Member

Let me know of any changes I should make.

r? @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@GuillaumeGomez
Copy link
Member

We generally put examples at the end of the doc. Please move it and then I'll r+.

@Mark-Simulacrum
Copy link
Member Author

Should I move the other examples in the same file? I put the example in the same place as in the AsRef documentation.

@GuillaumeGomez
Copy link
Member

No, don't bother. Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Sep 16, 2016

📌 Commit 102ee5e has been approved by GuillaumeGomez

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Sep 16, 2016
…illaumeGomez

Add example in AsMut trait documentation

Let me know of any changes I should make.

r? @GuillaumeGomez
bors added a commit that referenced this pull request Sep 16, 2016
Rollup of 8 pull requests

- Successful merges: #36383, #36424, #36480, #36484, #36505, #36509, #36519, #36521
- Failed merges:
@bors bors merged commit 102ee5e into rust-lang:master Sep 16, 2016
@Mark-Simulacrum Mark-Simulacrum deleted the example-asmut branch September 16, 2016 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants