-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call arrays "arrays" instead of "vecs" internally #36599
Call arrays "arrays" instead of "vecs" internally #36599
Conversation
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Manishearth r=me
BoxMutability, | ||
PtrMutability, | ||
RefMutability, | ||
VecMutability, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😆
☔ The latest upstream changes (presumably #36551) made this pull request unmergeable. Please resolve the merge conflicts. |
r=me. @Manishearth I'm guessing this should be part of a syntax breaking-batch? |
Yep. Let me know if you need a batch, this seems like something that can bitrot soon. |
☔ The latest upstream changes (presumably #36764) made this pull request unmergeable. Please resolve the merge conflicts. |
☔ The latest upstream changes (presumably #36601) made this pull request unmergeable. Please resolve the merge conflicts. |
These weren't flagged by the lint because they were still technically created somewhere... if you created them before, somehow.
This applies the HIR changes from the previous commits to the AST, and is thus a syntax-[breaking-change] Renames `PatKind::Vec` to `PatKind::Slice`, since these are called slice patterns, not vec patterns. Renames `TyKind::Vec`, which represents the type `[T]`, to `TyKind::Slice`. Renames `TyKind::FixedLengthVec` to `TyKind::Array`.
@Manishearth Okay, let's do a batch, this bitrots really quickly |
Yep. I plan to do one soon, but I'm at a conference and will be traveling tomorrow so I can't do it until Saturdayish |
…orite-data-structure, r= Contains a syntax-[breaking-change] as a separate commit (cc rust-lang#31645).nnAlso renames slice patterns from `PatKind::Vec` to `PatKind::Slice`.
…orite-data-structure, r=pnkfelix Contains a syntax-[breaking-change] as a separate commit (cc rust-lang#31645).nnAlso renames slice patterns from `PatKind::Vec` to `PatKind::Slice`.
Contains a syntax-[breaking-change] as a separate commit (cc #31645).
Also renames slice patterns from
PatKind::Vec
toPatKind::Slice
.