Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor modifications in concurrency section of the Rust book #36957

Merged
merged 1 commit into from
Oct 6, 2016

Conversation

nikhilshagri
Copy link
Contributor

between threads, but shared mutable data is unsafe and when threads are
involved can cause data races!
between threads, but shared mutable data is unsafe-and when threads are
involved-can cause data races!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very minor detail, but is it possible you could use the 'dash' character (—) instead of a 'hyphen' character (-) for this?

https://owl.english.purdue.edu/engagement/3/7/98/

@frewsxcv
Copy link
Member

frewsxcv commented Oct 4, 2016

Minus the punctuation change, looks good to me!

@nikhilshagri
Copy link
Contributor Author

@frewsxcv Fixed it!

@frewsxcv
Copy link
Member

frewsxcv commented Oct 4, 2016

Strange, it looks like there are two hyphens now. Do you also see that in the diff?

@nikhilshagri
Copy link
Contributor Author

It appears like that in the diff, but I think the two hyphens are automatically fused together to form a larger hyphen in the actual markdown page. I haven't checked yet.

@GuillaumeGomez
Copy link
Member

I see them as two hyphens as well. Dark magic.

@nikhilshagri
Copy link
Contributor Author

Fixed it. I was under the impression that the long dash is formed by joining the two small dashes. To rectify this, I actually copied the dash character from here and pasted it in the code because I wasn't able to find a way to type it from my keyboard 😅

@frewsxcv
Copy link
Member

frewsxcv commented Oct 4, 2016

Looks great, thanks! r=me

@steveklabnik
Copy link
Member

@bors: r=frewsxcv

Thanks so much @cynicaldevil !

(And yay to @frewsxcv 's first official docs review 🎊 )

@bors
Copy link
Contributor

bors commented Oct 4, 2016

📌 Commit 335d393 has been approved by frewsxcv

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Oct 6, 2016
Minor modifications in concurrency section of the Rust book

Fixes rust-lang#36939
r? @steveklabnik
bors added a commit that referenced this pull request Oct 6, 2016
@bors bors merged commit 335d393 into rust-lang:master Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants