Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incr. comp. hash tests for consts and statics #37040

Merged
merged 2 commits into from
Oct 12, 2016

Conversation

flodiebold
Copy link
Member

Hi,

These two commits fix #37000 and #37001.

r? @michaelwoerister

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @michaelwoerister (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@michaelwoerister
Copy link
Member

Thanks a lot for the PR, @flodiebold! I'll take a look at it as soon as I find the time.

@michaelwoerister
Copy link
Member

I've just reviewed this and I don't have a single complaint :) Thank you so much for the PR, @flodiebold!

@michaelwoerister
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 10, 2016

📌 Commit eb07a6c has been approved by michaelwoerister

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Oct 11, 2016
…rister

Incr. comp. hash tests for consts and statics

Hi,

These two commits fix rust-lang#37000 and rust-lang#37001.

r? @michaelwoerister
bors added a commit that referenced this pull request Oct 11, 2016
Rollup of 9 pull requests

- Successful merges: #36679, #36699, #36997, #37040, #37060, #37065, #37072, #37073, #37081
- Failed merges:
@bors bors merged commit eb07a6c into rust-lang:master Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incr.comp.: Create Test Case for Incr. Comp. Hash for const declarations
4 participants