macros: expand #[derive]s after other attribute macros and improve intra-#[derive] ordering
#37067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jseyfried
changed the title
#[derive]s after other macro invocations and improve intra-#[derive] ordering#[derive]s after other attribute macros and improve intra-#[derive] ordering
jseyfried
force-pushed
the
expand_derives_last
branch
from
db51187 to
8aa6b5c
Compare
|
@bors: r+ Thanks @jseyfried! |
|
📌 Commit 8aa6b5c has been approved by |
53 tasks
sgrif
reviewed
Oct 10, 2016
| if mitem.value_str().is_some() { | ||
| cx.span_err(mitem.span, "unexpected value in `derive`"); | ||
| let mut derive_attrs = Vec::new(); | ||
| item = item.map_attrs(|attrs| attrs.into_iter().filter_map(|attr| { |
There was a problem hiding this comment.
Could this use Iterator#partition instead?
There was a problem hiding this comment.
Good point, amended.
jseyfried
force-pushed
the
expand_derives_last
branch
from
8aa6b5c to
448d6ad
Compare
|
@bors r=alexcrichton |
|
📌 Commit 448d6ad has been approved by |
|
cc @nrc |
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Oct 11, 2016
…excrichton macros: expand `#[derive]`s after other attribute macros and improve intra-`#[derive]` ordering Fixes serde-rs/serde#577. cc rust-lang#35900 r? @alexcrichton
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Oct 12, 2016
…excrichton macros: expand `#[derive]`s after other attribute macros and improve intra-`#[derive]` ordering Fixes serde-rs/serde#577. cc rust-lang#35900 r? @alexcrichton
bors
added a commit
that referenced
this pull request
Oct 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes serde-rs/serde#577.
cc #35900
r? @alexcrichton