improve "Doesn't live long enough" error

[mikhail-m1]

I've fixed only with same case

issue #36537 part of #35233
r? @jonathandturner

[sophiajt]

This direction feels like an improvement, though looking back at #36537 I recall we'd decided that it would be something like:

struct_span_error(line 5 at '}, ....)
span_label(line 4 at 'a', "borrow occurs here")
span_label(line 5 at '}', "a dropped here while still borrowed")

It looks like you moved the span to the end of the block, which sounds right. I didn't see the labels for some of the errors you updated. You should add those, too, as I think they'll help the error messages be more readable.

You may also want to consider moving the tests you're updating to be UI tests. You can see examples in src/test/ui. They're pretty straightforward, the .stderr file just captures what the output is expected to look like.

[mikhail-m1]

@jonathandturner Should I move all changed tests to ui?

[sophiajt]

@mikhail-m1 - feel free to move all the tests you're updating with this PR to UI

[mikhail-m1]

@jonathandturner I created new directory in ui, is it ok?

[sophiajt]

@mikhail-m1 - you can put them in src/test/ui/span

[mikhail-m1]

@jonathandturner was moved

[sophiajt]

@bors r+

[bors]

📌 Commit 842b79d has been approved by jonathandturner

[mikhail-m1]

two new tests in master branch

[sophiajt]

@bors r-

Yeah, looks like there are a few that need to be updated:

    [compile-fail] compile-fail/dropck_tarena_cycle_checked.rs
    [compile-fail] compile-fail/dropck_tarena_unsound_drop.rs

[mikhail-m1]

@jonathandturner I cannot find this files in master branch. All cfail tests passes.

edit: I've found in cfail-full

[mikhail-m1]

@jonathandturner Should I put tests from compile-fail-fulldeps in ui too? There is no ui-fulldeps.

[sophiajt]

@mikhail-m1 you can leave the fulldeps tests where they are. I'm not 100% sure they'll work as ui tests.

[mikhail-m1]

test [ui] ui/dropck/dropck-eyepatch-extern-crate.rs ... FAILED
test [ui] ui/dropck/dropck-eyepatch-reorder.rs ... FAILED
test [ui] ui/dropck/dropck-eyepatch.rs ... FAILED

[mikhail-m1]

@jonathandturner fixed

[sophiajt]

@mikhail-m1 I think this is ready to land.

The wording for the temporary values can also be updated, but that can happen in a separate PR.

@bors r+

[bors]

📌 Commit e852775 has been approved by jonathandturner

[bors]

⌛ Testing commit e852775 with merge a6fa572...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: jonathandturner
Pushing a6fa572 to master...