Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable jemalloc on aarch64/powerpc #37392

Merged
merged 1 commit into from
Oct 30, 2016

Conversation

alexcrichton
Copy link
Member

Sounds like jemalloc is broken on systems which differ in page size than the
host it was compiled on (unless an option was passed). This unfortunately
reduces the portability of binaries created and can often make Rust segfault by
default. For now let's patch over this by disabling jemalloc until we can figure
out a better solution.

Closes #36994
Closes #37320
cc jemalloc/jemalloc#467

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

r? @brson

@xen0n
Copy link
Contributor

xen0n commented Oct 25, 2016

Multiple page sizes are also present on MIPS, both the 32- and 64-bit variants. Would be a good idea to include those too. :-)

@alexcrichton alexcrichton force-pushed the more-disable-jemalloc branch from c0ca239 to 0f6fde2 Compare October 25, 2016 15:56
@alexcrichton
Copy link
Member Author

@xen0n ah, sounds good to protect against as well! I've disabled it there as well.

@@ -25,6 +25,10 @@ pub fn target() -> TargetResult {
cpu: "mips64r2".to_string(),
features: "+mips64r2".to_string(),
max_atomic_width: Some(64),

// see #36994
exe_allocation_crate: "alloc_system".to_string();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis failed because all these MIPS additions should end in commas, not semicolons.

Sounds like jemalloc is broken on systems which differ in page size than the
host it was compiled on (unless an option was passed). This unfortunately
reduces the portability of binaries created and can often make Rust segfault by
default. For now let's patch over this by disabling jemalloc until we can figure
out a better solution.

Closes rust-lang#36994
Closes rust-lang#37320
cc jemalloc/jemalloc#467
@alexcrichton alexcrichton force-pushed the more-disable-jemalloc branch from 0f6fde2 to de80670 Compare October 27, 2016 15:08
@brson
Copy link
Contributor

brson commented Oct 27, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Oct 27, 2016

📌 Commit de80670 has been approved by brson

@sfackler
Copy link
Member

omg jemalloc

@bors
Copy link
Contributor

bors commented Oct 29, 2016

⌛ Testing commit de80670 with merge 62bdf88...

bors added a commit that referenced this pull request Oct 29, 2016
Disable jemalloc on aarch64/powerpc

Sounds like jemalloc is broken on systems which differ in page size than the
host it was compiled on (unless an option was passed). This unfortunately
reduces the portability of binaries created and can often make Rust segfault by
default. For now let's patch over this by disabling jemalloc until we can figure
out a better solution.

Closes #36994
Closes #37320
cc jemalloc/jemalloc#467
@bors
Copy link
Contributor

bors commented Oct 30, 2016

💔 Test failed - auto-linux-64-opt

@alexcrichton
Copy link
Member Author

@bors: retry

On Sat, Oct 29, 2016 at 8:28 PM, bors notifications@github.com wrote:

💔 Test failed - auto-linux-64-opt
https://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/10825


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#37392 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95PIffOMf5PiEF3ArjsytuI7F0F2gks5q4-SZgaJpZM4Kff3U
.

@bors
Copy link
Contributor

bors commented Oct 30, 2016

⌛ Testing commit de80670 with merge aef5ca5...

bors added a commit that referenced this pull request Oct 30, 2016
Disable jemalloc on aarch64/powerpc

Sounds like jemalloc is broken on systems which differ in page size than the
host it was compiled on (unless an option was passed). This unfortunately
reduces the portability of binaries created and can often make Rust segfault by
default. For now let's patch over this by disabling jemalloc until we can figure
out a better solution.

Closes #36994
Closes #37320
cc jemalloc/jemalloc#467
@bors bors merged commit de80670 into rust-lang:master Oct 30, 2016
@bluss bluss added the relnotes Marks issues that should be documented in the release notes of the next release. label Oct 30, 2016
@alexcrichton alexcrichton deleted the more-disable-jemalloc branch November 6, 2016 16:34
infinity0 added a commit to infinity0/rust that referenced this pull request Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants