-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable jemalloc on aarch64/powerpc #37392
Conversation
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
r? @brson |
Multiple page sizes are also present on MIPS, both the 32- and 64-bit variants. Would be a good idea to include those too. :-) |
c0ca239
to
0f6fde2
Compare
@xen0n ah, sounds good to protect against as well! I've disabled it there as well. |
@@ -25,6 +25,10 @@ pub fn target() -> TargetResult { | |||
cpu: "mips64r2".to_string(), | |||
features: "+mips64r2".to_string(), | |||
max_atomic_width: Some(64), | |||
|
|||
// see #36994 | |||
exe_allocation_crate: "alloc_system".to_string(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis failed because all these MIPS additions should end in commas, not semicolons.
Sounds like jemalloc is broken on systems which differ in page size than the host it was compiled on (unless an option was passed). This unfortunately reduces the portability of binaries created and can often make Rust segfault by default. For now let's patch over this by disabling jemalloc until we can figure out a better solution. Closes rust-lang#36994 Closes rust-lang#37320 cc jemalloc/jemalloc#467
0f6fde2
to
de80670
Compare
@bors r+ |
📌 Commit de80670 has been approved by |
omg jemalloc |
Disable jemalloc on aarch64/powerpc Sounds like jemalloc is broken on systems which differ in page size than the host it was compiled on (unless an option was passed). This unfortunately reduces the portability of binaries created and can often make Rust segfault by default. For now let's patch over this by disabling jemalloc until we can figure out a better solution. Closes #36994 Closes #37320 cc jemalloc/jemalloc#467
💔 Test failed - auto-linux-64-opt |
@bors: retry On Sat, Oct 29, 2016 at 8:28 PM, bors notifications@github.com wrote:
|
Disable jemalloc on aarch64/powerpc Sounds like jemalloc is broken on systems which differ in page size than the host it was compiled on (unless an option was passed). This unfortunately reduces the portability of binaries created and can often make Rust segfault by default. For now let's patch over this by disabling jemalloc until we can figure out a better solution. Closes #36994 Closes #37320 cc jemalloc/jemalloc#467
Sounds like jemalloc is broken on systems which differ in page size than the
host it was compiled on (unless an option was passed). This unfortunately
reduces the portability of binaries created and can often make Rust segfault by
default. For now let's patch over this by disabling jemalloc until we can figure
out a better solution.
Closes #36994
Closes #37320
cc jemalloc/jemalloc#467