Add identifier to unused import warnings #37394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @pnkfelix |
oli-obk
reviewed
Oct 25, 2016
| @@ -17,19 +17,19 @@ use std::mem::*; // shouldn't get errors for not using | |||
| // everything imported | |||
|
|
|||
| // Should get errors for both 'Some' and 'None' | |||
| use std::option::Option::{Some, None}; //~ ERROR unused import | |||
| //~^ ERROR unused import | |||
| use std::option::Option::{Some, None}; //~ ERROR unused import `Some` | |||
There was a problem hiding this comment.
you forgot to add the colons after unused import
There was a problem hiding this comment.
Of all the silly things... Good catch!
|
Once the semi-colons have been added, it'll be good for me. |
cramertj
force-pushed
the
cramertj/unused-import-with-id
branch
from
54a73d7 to
2bd9418
Compare
cramertj
changed the title
|
@GuillaumeGomez Colons added 😄 |
|
Thanks! @bors: r+ rollup |
|
📌 Commit 2bd9418 has been approved by |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Oct 26, 2016
…h-id, r=GuillaumeGomez Add identifier to unused import warnings Fix rust-lang#37376. For some reason, though, I'm getting warnings with messages like "76:9: 76:16: unused import: `self::g`" instead of "unused import: `self::g`". @pnkfelix Any ideas what might be causing this?
bors
added a commit
that referenced
this pull request
Oct 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #37376.
For some reason, though, I'm getting warnings with messages like "76:9: 76:16: unused import:
self::g" instead of "unused import:self::g". @pnkfelix Any ideas what might be causing this?