-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --emit metadata #37411
Add --emit metadata #37411
Conversation
With the same semantics as -Zno-trans
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This isn't quite what I personally had in mind for this flag, but rather something like:
I feel like we definitely want a separate artifact here to avoid the compiler getting confused with "rlibs with code" and "rlibs with only metadata", and it'd also help build systems and such as it wouldn't all generate to the same file. |
@alexcrichton that is a much bigger change, I'd want to be sure there was a big benefit to this. ISTM that we can get a lot of that benefit from just building into a different directory (e.g., Cargo could have a check directory in addition to release and debug). I had hoped we could keep a strict separation between code and metadata libs without having to rely on the file type. |
It is indeed a much bigger change, yeah. I do agree that the implementation of @brson will also likely have opinions on this as well! |
☔ The latest upstream changes (presumably #37400) made this pull request unmergeable. Please resolve the merge conflicts. |
I also assumed (and would expect) a design like the one that @alexcrichton proposed. It is certainly a somewhat bigger change -- but not that much, right? |
ping @brson - thoughts? |
Closing in favour of #37681 |
With the same semantics as -Zno-trans
cc @rust-lang/compiler @rust-lang/tools
r? @alexcrichton