Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated fixme comment. #37462

Merged
merged 1 commit into from
Oct 31, 2016

Conversation

Mark-Simulacrum
Copy link
Member

Linked issue has been closed, but the comment was not removed.

If this is still an issue, then the comment should probably be updated.

r? @petrochenkov

@petrochenkov
Copy link
Contributor

Technically, the comment is still correct, but that code is frozen and used only to faithfully reproduce the "old buggy behavior" needed for reporting private_in_public compatibility lint, so it's not an issue anymore.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 29, 2016

📌 Commit 709a06b has been approved by petrochenkov

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Oct 31, 2016
…me, r=petrochenkov

Remove outdated fixme comment.

Linked issue has been closed, but the comment was not removed.

If this is still an issue, then the comment should probably be updated.

r? @petrochenkov
bors added a commit that referenced this pull request Oct 31, 2016
Rollup of 5 pull requests

- Successful merges: #37438, #37458, #37462, #37475, #37486
- Failed merges:
@bors bors merged commit 709a06b into rust-lang:master Oct 31, 2016
@Mark-Simulacrum Mark-Simulacrum deleted the remove-obsolete-fixme branch December 27, 2016 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants