Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shrink hir::Expr slightly #37577

Merged
merged 2 commits into from
Nov 6, 2016
Merged

Shrink hir::Expr slightly #37577

merged 2 commits into from
Nov 6, 2016

Conversation

nnethercote
Copy link
Contributor

#37445 shrunk hir::Expr by 80 bytes. This PR shaves another 16 bytes off, which will help #36799 a little.

r? @eddyb

@nnethercote
Reorder hir::Expr fields.
9366ba3 
On 64-bit platforms this reduces the size of `Expr` from 96 bytes to 88
bytes.
@nnethercote
Shrink Expr_::ExprStruct.
43452a3 
On 64-bit platforms this reduces the size of `Expr_` from  64 bytes to
56 bytes, and reduces the size of `Expr` from 88 bytes to 80 bytes.
@eddyb
Copy link
Member

eddyb commented Nov 4, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Nov 4, 2016

📌 Commit 43452a3 has been approved by eddyb

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Nov 4, 2016
Rollup merge of rust-lang#37577 - nnethercote:shrink-Expr-slightly, r…
323ce27 
…=eddyb

Shrink `hir::Expr` slightly

r? @eddyb
@sophiajt sophiajt mentioned this pull request Nov 4, 2016
Closed
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Nov 4, 2016
@alexcrichton
Rollup merge of rust-lang#37577 - nnethercote:shrink-Expr-slightly, r…
d47d549 
…=eddyb

Shrink `hir::Expr` slightly

r? @eddyb
@alexcrichton alexcrichton mentioned this pull request Nov 4, 2016
Merged
bors added a commit that referenced this pull request Nov 5, 2016
@bors
Auto merge of #37597 - alexcrichton:rollup, r=alexcrichton
16d5330 
Rollup of 24 pull requests

- Successful merges: #37255, #37317, #37408, #37410, #37422, #37427, #37470, #37501, #37537, #37556, #37557, #37564, #37565, #37566, #37569, #37574, #37577, #37579, #37583, #37585, #37586, #37587, #37589, #37596
- Failed merges: #37521, #37547
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Nov 5, 2016
Rollup merge of rust-lang#37577 - nnethercote:shrink-Expr-slightly, r…
12f814e 
…=eddyb

Shrink `hir::Expr` slightly

r? @eddyb
@sophiajt sophiajt mentioned this pull request Nov 5, 2016
Closed
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Nov 5, 2016
@alexcrichton
Rollup merge of rust-lang#37577 - nnethercote:shrink-Expr-slightly, r…
07cf4b4 
…=eddyb

Shrink `hir::Expr` slightly

r? @eddyb
bors added a commit that referenced this pull request Nov 6, 2016
@bors
Auto merge of #37597 - alexcrichton:rollup, r=alexcrichton
3fc8304 
Rollup of 24 pull requests

- Successful merges: #37255, #37317, #37408, #37410, #37422, #37427, #37470, #37501, #37537, #37556, #37557, #37564, #37565, #37566, #37569, #37574, #37577, #37579, #37583, #37585, #37586, #37587, #37589, #37596
- Failed merges: #37521, #37547
@bors bors merged commit 43452a3 into rust-lang:master Nov 6, 2016
@nnethercote nnethercote deleted the shrink-Expr-slightly branch November 6, 2016 21:25
@nnethercote nnethercote mentioned this pull request Nov 7, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nnethercote @eddyb @bors