Marking the 'no-stack-check' codegen option as deprecated (Issue #34915) #37636
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -1011,6 +1011,10 @@ pub fn handle_options(args: &[String]) -> Option<getopts::Matches> { | |||
| return None; | |||
| } | |||
|
|
|||
| if cg_flags.iter().any(|x| *x == "no-stack-check") { | |||
| println!("warning: the --no-stack-check flag is deprecated and does nothing"); | |||
There was a problem hiding this comment.
instead of calling println! directly, it would be better to invoke early_warn, sort of like this code:
let msg = format!("the option `{}` is unstable and should \
only be used on the nightly compiler, but \
it is currently accepted for backwards \
compatibility; this will soon change, \
see issue #31847 for more details",
opt_name);
early_warn(ErrorOutputType::default(), &msg);
|
Thanks for picking this up! See my suggestion above. =) |
karpinski
force-pushed
the
issue-34915
branch
from
35f2202 to
c670293
Compare
|
Looks good to me! :) @bors r+ |
|
📌 Commit c670293 has been approved by |
Marking the 'no-stack-check' codegen option as deprecated (Issue rust-lang#34915) Attempts to finish resolving issue rust-lang#34915. Based on pull request rust-lang#35156, which was closed due to inactivity.
Attempts to finish resolving issue #34915. Based on pull request #35156, which was closed due to inactivity.