Rollup of 8 pull requests #37657
Merged
Rollup of 8 pull requests #37657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
Nov 8, 2016
steveklabnik
commented
- Successful merges: Make it clear that the reference isn't normative #35102, Add error note to illegal code snippet #37425, Match guessing game output to newest language version #37483, Add missing urls on io structs #37588, book: Removed platform compatibility table, link to the forge #37601, Add unary and binary tests for incr-comp #37610, Add missing urls for Sum and Product traits #37650, More proeminent warning in Arc::{strong,weak}_count docs. #37652
- Failed merges:
Any time someone edits the reference, it has to be taken very seriously, since it's the closest thing we have to a specification. This commit adds language which indicates that this is not a normative document, which makes it easier to make tweaks without worrying about forever harming the future of Rust by painting ourselves in a corner.
Cargo now informs that it has finished, and there is new error format.
The content is duplicated, and it doesn't need to be in this location. It's mostly trivia that doesn't apply to most of the audience. The forge is up to date.
Said code review and recommendations can be found here: rust-lang#37610
Make it clear that the reference isn't normative Any time someone edits the reference, it has to be taken very seriously, since it's the closest thing we have to a specification. This commit adds language which indicates that this is not a normative document, which makes it easier to make tweaks without worrying about forever harming the future of Rust by painting ourselves in a corner. r? @aturon
Add error note to illegal code snippet Mark intentionally invalid code snippet in documentation as such with a comment. Similar comments used elsewhere in this file. r? @steveklabnik
Match guessing game output to newest language version Cargo now informs that it has finished, and there is new error format.
…rewsxcv Add missing urls on io structs r? @steveklabnik
…abnik book: Removed platform compatibility table, link to the forge The content is duplicated, and it doesn't need to be in this location. It's mostly trivia that doesn't apply to most of the audience. The forge is up to date. r? @steveklabnik cc @alexcrichton
…r=michaelwoerister Add unary and binary tests for incr-comp This is my draft of tests for unary and binary expressions as desired by rust-lang#37520 for use in the test suite for hashes in incremental compilation. Feedback would be wonderful, if there's any changes I need to make I would appreciate the code review. ?r @michaelwoerister
…, r=steveklabnik Add missing urls for Sum and Product traits r? @steveklabnik
…chton
More proeminent warning in Arc::{strong,weak}_count docs.
CC rust-lang#28356 (comment)
|
r? @Manishearth (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1 |
|
📌 Commit 5c92c2c has been approved by |
bors
added a commit
that referenced
this pull request
Nov 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.