Remove scope_auxiliary.
#37764
Remove scope_auxiliary.
#37764
Conversation
This reduces the peak RSS for a cut-down version of the program in rust-lang#36799 by 10%, from 951MB to 856MB.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
I think we decided we are going to take a different approach on the MIR size thing. |
|
@arielb1 did we have another use in mind for scope-auxiliary? I think it is not needed (the MIR dumping is, I think, just so that we can see what was being generated). I had originally thought we would use it for borrowck -- and I still want to do a version of borrowck that uses scopes as a first step. @pnkfelix is supposed to be investigating. However, we had agreed we'd just try to add in the scopes that we actually need -- i.e., those that are targeted by a borrow. Seems fine to remove what we have (esp. for a 10% win) and come back with a clean-slate approach. cc @rust-lang/compiler -- thoughts? |
|
I am fine with removing it if MIR borrowck won't use it. |
brson
added
the
relnotes
|
@bors r+ |
|
📌 Commit d775570 has been approved by |
|
let's do it. we can always put it back. |
…akis Remove `scope_auxiliary`. `scope_auxiliary` is a big part of the high memory usage in #36799. It's only used for MIR dumping. I have taken a hubristic approach: I have assumed that particular use is unimportant and removed `scope_auxiliary` and related things. This reduces peak RSS by ~10% for a cut-down version of the program in #36799. If that assumption is wrong perhaps we can avoid building `scope_auxiliary` unless MIR dumping is enabled.
scope_auxiliaryis a big part of the high memory usage in #36799. It's only used for MIR dumping. I have taken a hubristic approach: I have assumed that particular use is unimportant and removedscope_auxiliaryand related things. This reduces peak RSS by ~10% for a cut-down version of the program in #36799.If that assumption is wrong perhaps we can avoid building
scope_auxiliaryunless MIR dumping is enabled.