ICH: Handle MacroDef HIR instances. #37787
Conversation
| // Since this is hardly used anywhere, just emit a | ||
| // warning for now. | ||
| if self.tcx.sess.opts.debugging_opts.incremental.is_some() { | ||
| let msg = format!("Quasi-quoting might make incremental \ |
There was a problem hiding this comment.
Shouldn't this warning be rate-limited and spanned?
There was a problem hiding this comment.
Yes, I could thread a span through for error reporting.
There was a problem hiding this comment.
Also, nit: lower-case "quasi-quoting might...."
But span seems pretty useful
michaelwoerister
force-pushed
the
macro-def-ich
branch
from
5ee1acf to
fcf85f1
Compare
|
Added a span to the warning. |
|
@michaelwoerister style nit: warnings begin with lower-case letter I think. other than, r=me |
|
@bors r=nikomatsakis For things like this (changing the text of a warning message), the online-editing feature is really rather convenient. |
|
📌 Commit 23730a9 has been approved by |
|
☔ The latest upstream changes (presumably #37660) made this pull request unmergeable. Please resolve the merge conflicts. |
michaelwoerister
force-pushed
the
macro-def-ich
branch
from
23730a9 to
c722a1e
Compare
|
@bors r=nikomatsakis Rebased. |
|
📌 Commit c722a1e has been approved by |
ICH: Handle MacroDef HIR instances. As of recently, `hir::MacroDef` instances are exported in crate metadata, which means we also store their ICH when doing incremental compilation. Even though exported macro definitions should not (yet) interact with incremental compilation, the ICH is also used for the general purpose crate hash, where macros should be included. This PR implements ICH computation for `MacroDef`. In theory, the ICH of these MacroDefs is less stable than that of other HIR items, since I opted to just call the compiler-generated `Hash::hash()` for `Token::Interpolated` variants. `Token::Interpolated` contains AST data structures and it would have been a lot of effort to expand ICH computation to the AST too. Since quasi-quoting is rarely used *and* it would only make a difference if incremental compilation was extended to macros, the simpler implementation seemed like a good idea. This fixes the problem reported in #37756. The test still fails because of broken codegen-unit support though. r? @nikomatsakis
As of recently,
hir::MacroDefinstances are exported in crate metadata, which means we also store their ICH when doing incremental compilation. Even though exported macro definitions should not (yet) interact with incremental compilation, the ICH is also used for the general purpose crate hash, where macros should be included.This PR implements ICH computation for
MacroDef. In theory, the ICH of these MacroDefs is less stable than that of other HIR items, since I opted to just call the compiler-generatedHash::hash()forToken::Interpolatedvariants.Token::Interpolatedcontains AST data structures and it would have been a lot of effort to expand ICH computation to the AST too. Since quasi-quoting is rarely used and it would only make a difference if incremental compilation was extended to macros, the simpler implementation seemed like a good idea.This fixes the problem reported in #37756. The test still fails because of broken codegen-unit support though.
r? @nikomatsakis