Rollup of 8 pull requests #37830
Closed
Rollup of 8 pull requests #37830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impls with a erroneous trait ref are already ignored in the first part of coherence, so ignore them in the second part too. This avoids cascading coherence errors when 1 impl of a trait has an error.
Similar to pull request rust-lang#37430, this makes the message more copy-paste friendly and aligns it with other messages like: help: you can import it into scope: use foo::Bar;
…chapter of the book.
This is not true.
…sakis coherence: skip impls with an erroneous trait ref Impls with a erroneous trait ref are already ignored in the first part of coherence, so ignore them in the second part too. This avoids cascading coherence errors when 1 impl of a trait has an error. r? @nikomatsakis
Uncomment some long error explanation Retry of rust-lang#37058. r? @steveklabnik cc @brson
…olon, r=eddyb Add semicolon to "perhaps add a `use` for one of them" help Similar to pull request rust-lang#37430, this makes the message more copy-paste friendly and aligns it with other messages like: help: you can import it into scope: use foo::Bar; r? @eddyb
…ure, r=steveklabnik Add sections about testing concurrency and stdout/err capture
add test for rust-lang#37765 Adds a test for rust-lang#37765, a path parsing fix which removes the need for a parenthesis workaround. Closes rust-lang#37765. cc rust-lang#37290 @withoutboats r? @petrochenkov
…, r=nikomatsakis ICH: Add test case for type alias definitions r? @nikomatsakis
…sxcv Net examples r? @steveklabnik
…ence-comment, r=GuillaumeGomez Remove incorrect statement about the reference. This is not true.
|
@bors: r+ p=1 |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
📌 Commit 75941eb has been approved by |
|
@GuillaumeGomez I actually agree with @petrochenkov about #37820, i'd like to fix it up. can you do a rollup with it? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usefor one of them" help #37759, Add sections about testing concurrency and stdout/err capture #37766, add test for #37765 #37772, ICH: Add test case for type alias definitions #37799, Net examples #37806, Remove incorrect statement about the reference. #37820