Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate function bodies from their signatures in HIR #37918

Merged
merged 37 commits into from
Nov 29, 2016
Merged

Separate function bodies from their signatures in HIR #37918

merged 37 commits into from
Nov 29, 2016

Commits on Nov 29, 2016

  1. Add exprs map to crate, collect item blocks there

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    069a244 View commit details
    Browse the repository at this point in the history

  2. rustc: replace body exprs by their ids

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    f55482e View commit details
    Browse the repository at this point in the history

  3. rustc_const_eval: fix compilation

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    8e75473 View commit details
    Browse the repository at this point in the history

  4. rustc_mir: fix compilation

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    8f6bb85 View commit details
    Browse the repository at this point in the history

  5. rustc_borrowck: fix compilation

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    8c8257a View commit details
    Browse the repository at this point in the history

  6. rustc_typeck: fix compilation

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    b7a6cf8 View commit details
    Browse the repository at this point in the history

  7. rustc_incremental: fix compilation

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    490c23f View commit details
    Browse the repository at this point in the history

  8. rustc_incremental: fix compilation

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    2f6976e View commit details
    Browse the repository at this point in the history

  9. rustc_trans: fix compilation

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    8f63b41 View commit details
    Browse the repository at this point in the history

  10. rustc_trans: fix compilation

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    dd6a57c View commit details
    Browse the repository at this point in the history

  11. rustc_privacy: fix compilation

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    0cdd1d4 View commit details
    Browse the repository at this point in the history

  12. rustc_metadata: fix compilation

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    441e099 View commit details
    Browse the repository at this point in the history

  13. rustc_plugin: fix compilation

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    2b790f7 View commit details
    Browse the repository at this point in the history

  14. rustc_plugin: fix compilation

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    37e7541 View commit details
    Browse the repository at this point in the history

  15. rustc_passes: fix compilation

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    0389cc6 View commit details
    Browse the repository at this point in the history

  16. rustc_driver: fix compilation

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    1ac338c View commit details
    Browse the repository at this point in the history

  17. Save bodies of functions for inlining into other crates 

    This is quite hacky and I hope to refactor it a bit, but at least it
seems to work.
    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    16eedd2 View commit details
    Browse the repository at this point in the history

  18. Give function bodies their own dep graph node

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    936dbbc View commit details
    Browse the repository at this point in the history

  19. Fix cross-crate associated constant evaluation

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    c91037b View commit details
    Browse the repository at this point in the history

  20. rustc_typeck: Make CollectItemTypesVisitor descend into bodies as well

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    fb968d2 View commit details
    Browse the repository at this point in the history

  21. Fix new tests

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    7b02129 View commit details
    Browse the repository at this point in the history

  22. Make hello_world test work again 

    This used to work with the rustc_clean attribute, but doesn't anymore
since my rebase; but I don't know enough about the type checking to find
out what's wrong. The dep graph looks like this:

ItemSignature(xxxx) -> CollectItem(xxxx)
CollectItem(xxxx) -> ItemSignature(xxxx)
ItemSignature(xxxx) -> TypeckItemBody(yyyy)
HirBody(xxxx) -> CollectItem(xxxx)

The cycle between CollectItem and ItemSignature looks wrong, and my
guess is the CollectItem -> ItemSignature edge shouldn't be there, but
I'm not sure how to prevent it.
    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    78b54c0 View commit details
    Browse the repository at this point in the history

  23. Fix some comments

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    8d5ca62 View commit details
    Browse the repository at this point in the history

  24. Remove unused import

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    23a8c7d View commit details
    Browse the repository at this point in the history

  25. Add make tidy fixes

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    f75c8a9 View commit details
    Browse the repository at this point in the history

  26. restructure CollectItem dep-node to separate fn sigs from bodies 

    Setup two tasks, one of which only processes the signatures, in order to
isolate the typeck entries for signatures from those for bodies.

Fixes rust-lang#36078
Fixes rust-lang#37720
    @nikomatsakis @flodiebold
    nikomatsakis authored and flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    688946d View commit details
    Browse the repository at this point in the history

  27. WIP: update tests to pass -- not complete

    @nikomatsakis @flodiebold
    nikomatsakis authored and flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    dd1491c View commit details
    Browse the repository at this point in the history

  28. Refactor inlined items some more 

    They don't implement FnLikeNode anymore, instead are handled differently
further up in the call tree. Also, keep less information (just def ids
for the args).
    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    d0ae2c8 View commit details
    Browse the repository at this point in the history

  29. Fix remaining SVH tests

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    d5a501d View commit details
    Browse the repository at this point in the history

  30. Address remaining review comments

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    725cffb View commit details
    Browse the repository at this point in the history

  31. Split nested_visit_mode function off from nested_visit_map 

    ... and make the latter mandatory to implement.
    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    f0ce5bb View commit details
    Browse the repository at this point in the history

  32. Fix SVH tests some more

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    b10bbde View commit details
    Browse the repository at this point in the history

  33. Fix doc test collection

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    bf298ae View commit details
    Browse the repository at this point in the history

  34. Fix rebase breakage

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    8575184 View commit details
    Browse the repository at this point in the history

  35. revamp Visitor with a single method for controlling nested visits

    @nikomatsakis @flodiebold
    nikomatsakis authored and flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    104125d View commit details
    Browse the repository at this point in the history

  36. update comments

    @nikomatsakis @flodiebold
    nikomatsakis authored and flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    9457497 View commit details
    Browse the repository at this point in the history

  37. librustdoc: Fix compilation after visitor change

    @flodiebold
    flodiebold committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    593b273 View commit details
    Browse the repository at this point in the history