Shrink token::Lit's hash count from usize to u16.
#38043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On 64-bit platforms, this reduces the size of `token::Lit` from 16 bytes to 8 bytes, and reduces the size of `token::Token` from 32 bytes to 24 bytes.
|
What is your motivation? What will it give? How much memory it will save? |
|
It's more about reducing memory traffic. Fewer bytes written, read, copied, etc. |
|
☔ The latest upstream changes (presumably #38148) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@eddyb: I think the compiler now auto-sorts fields to minimize struct size. Is that right? If so, this change shouldn't be necessary. |
|
We decided to revert field reordering for now, see #38523. |
|
Field reordering seems very likely to be turned on at some point, so let's close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 64-bit platforms, this reduces the size of
token::Litfrom 16 bytes to 8 bytes, and reduces the size oftoken::Tokenfrom 32 bytes to 24 bytes.There are two places where I could add overflow checks, and I've marked them with "njn" comments. It's unlikely that there would be more than 65535 '#' marks at the start of a raw string, but I can add a check if you think it's worthwhile.
r? @eddyb