-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename 'librustc_unicode' crate to 'libstd_unicode'. #38049
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look fine so far - question is just if unicode
is maybe a too general name for its std-specific purpose.
Discussed a bit during triage and conclusion was that a name like |
Changes have been made in the latest force push. |
@bors: r+ |
📌 Commit c904a36 has been approved by |
Presumably the Makefiles will need to be updated as well. This was attempted before: #36806. |
Good catch. Fixed in the latest force push. r? @alexcrichton |
@bors: r+ |
📌 Commit 274777a has been approved by |
@bors r=-50 This is not super important. Doesn't need to be prioritized. |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit 274777a has been approved by |
@bors r=alexcrichton p=-50 |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit 274777a has been approved by |
AFAIR according to #24428, the rustc_unicode crate is supposed to be a facade for the compiler itself? In that case rustc_unicode makes very much sense to me. |
|
Rename 'librustc_unicode' crate to 'libstd_unicode'. Fixes #26554.
Fixes #26554.