Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RFC #1260 #38312

Closed
wants to merge 1 commit into from
Closed

Implement RFC #1260 #38312

wants to merge 1 commit into from

Conversation

bombless
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@bombless
Copy link
Contributor Author

bombless commented Dec 12, 2016

So the libsyntax/entry.rs need a little bit clean up to make those comments to be correct.
But tbh that entry_point_type function serve a different purpose, that is, to mark main-like function #[allow(dead_code)] and to remove start attribute.
But it's not really about entry point, rather, it can just remove all start attribute and make the dead_code lint ignore start and main items, as well as function named "main" in root namespace.
Therefore I suggest it's just improper at first place, and I'll improve it at next PR.

@bombless
Copy link
Contributor Author

cc #28937

@bombless bombless changed the title Implement RFC 1260 Implement RFC #1260 Dec 12, 2016
@petrochenkov
Copy link
Contributor

Can this RFC be reconsidered by the lang team?
This RFC adds a strange thing to the language and a special case to the compiler, and the motivation is very weak.

Also, @bombless, could you add a feature gate for this, so even if it's merged now it could be purged later?

@bombless
Copy link
Contributor Author

Added the feature-gate and the bootstrap hit a problem.. need to fix it first.

@bombless bombless closed this Dec 12, 2016
@joshtriplett
Copy link
Member

Why did this get closed? I'd love to see this implemented; I have a library that would benefit from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants