Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nomicon on drop flags #38555

Closed
wants to merge 1 commit into from
Closed

Conversation

sanxiyn
Copy link
Member

@sanxiyn sanxiyn commented Dec 22, 2016

@steveklabnik
Copy link
Member

Thank you! However, in documentation, we generally don't talk about versions of Rust like this. Could you instead cut everything but the actual explanation of how it's done today? Thanks!

@liigo
Copy link
Contributor

liigo commented Dec 24, 2016

Version is useful information here.

@liigo
Copy link
Contributor

liigo commented Dec 24, 2016

You mentioned version is stable version, right?

@steveklabnik
Copy link
Member

Docs are always written in the present tense; we distribute them with each version of Rust, so if you wanted to see how something works on a particular version, you'd download those docs. This is of course, modulo bugs like this. Regardless, including "since version x.y.z" isn't how we write any docs, so this should be in line with the rest of Rust's documentation.

@petrochenkov
Copy link
Contributor

"since version x.y.z" isn't how we write any docs

It's never late to start!
A small piece of history looks useful and fitting in this context, why throw it away in favor of some formalities.

@steveklabnik
Copy link
Member

Because we believe that it's a better way to write documentation.

Anyway, this isn't the right place to argue about it; a policy change here would need a docs RFC, so if you'd like this to land before then, you gotta make it fit with the current way we write docs, sorry.

@steveklabnik
Copy link
Member

ping @sanxiyn ! Can you make the change I requested, please?

from a time when you could do much more complex conditional initialization.

Since Rust 1.13, the flags has been moved to the stack frame where they more
reasonably belong, and types implementing Drop no more take up any extra space.
Copy link
Member

@pnkfelix pnkfelix Jan 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this should say "no longer take up any ...", not "no more take up any ..."

@pnkfelix pnkfelix added A-destructors Area: Destructors (`Drop`, …) A-docs labels Jan 3, 2017
@sanxiyn
Copy link
Member Author

sanxiyn commented Jan 4, 2017

I am not sure how best to reword this, maybe someone else can do so. Thanks for review!

@sanxiyn sanxiyn closed this Jan 4, 2017
@sanxiyn sanxiyn deleted the drop-flags branch January 4, 2017 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-destructors Area: Destructors (`Drop`, …)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants