-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nomicon on drop flags #38555
Update nomicon on drop flags #38555
Conversation
Thank you! However, in documentation, we generally don't talk about versions of Rust like this. Could you instead cut everything but the actual explanation of how it's done today? Thanks! |
Version is useful information here. |
You mentioned version is stable version, right? |
Docs are always written in the present tense; we distribute them with each version of Rust, so if you wanted to see how something works on a particular version, you'd download those docs. This is of course, modulo bugs like this. Regardless, including "since version x.y.z" isn't how we write any docs, so this should be in line with the rest of Rust's documentation. |
It's never late to start! |
Because we believe that it's a better way to write documentation. Anyway, this isn't the right place to argue about it; a policy change here would need a docs RFC, so if you'd like this to land before then, you gotta make it fit with the current way we write docs, sorry. |
ping @sanxiyn ! Can you make the change I requested, please? |
from a time when you could do much more complex conditional initialization. | ||
|
||
Since Rust 1.13, the flags has been moved to the stack frame where they more | ||
reasonably belong, and types implementing Drop no more take up any extra space. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this should say "no longer take up any ...", not "no more take up any ..."
I am not sure how best to reword this, maybe someone else can do so. Thanks for review! |
Fix #38481.
r? @steveklabnik